Skip to content

TRT-2349: Revert "make TLS registry tests required"#30358

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
neisw:revert-29074-cert-rotation-required-tests
Oct 9, 2025
Merged

TRT-2349: Revert "make TLS registry tests required"#30358
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
neisw:revert-29074-cert-rotation-required-tests

Conversation

@neisw
Copy link
Contributor

@neisw neisw commented Oct 9, 2025

Reverts #29074

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Multiple payload failures due to ROSA all registered tls artifacts must have no metadata violation regressions and all tls artifacts must be registered failures

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert

Unfortunately for ROSA we can not payload test to verify

CC: @vrutkovs

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 9, 2025

@neisw: This pull request references TRT-2349 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Reverts #29074

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Multiple payload failures due to ROSA all registered tls artifacts must have no metadata violation regressions and all tls artifacts must be registered failures

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert

Unfortunately for ROSA we can not payload test to verify

CC: @vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2025
@openshift-ci openshift-ci bot requested review from bparees and deads2k October 9, 2025 10:05
@stbenjam
Copy link
Member

stbenjam commented Oct 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member

stbenjam commented Oct 9, 2025

/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-microshift
/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-aws-ovn-serial-1of2
/override ci/prow/e2e-aws-ovn-serial-2of2
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-vsphere-ovn
/override ci/prow/e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial, ci/prow/e2e-aws-ovn-serial-1of2, ci/prow/e2e-aws-ovn-serial-2of2, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-vsphere-ovn, ci/prow/e2e-vsphere-ovn-upi

Details

In response to this:

/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-aws-ovn-microshift
/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-aws-ovn-serial-1of2
/override ci/prow/e2e-aws-ovn-serial-2of2
/override ci/prow/e2e-gcp-csi
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-vsphere-ovn
/override ci/prow/e2e-vsphere-ovn-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stbenjam
Copy link
Member

stbenjam commented Oct 9, 2025

/override ci/prow/okd-scos-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/okd-scos-e2e-aws-ovn

Details

In response to this:

/override ci/prow/okd-scos-e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stbenjam
Copy link
Member

stbenjam commented Oct 9, 2025

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 9, 2025
@openshift-ci-robot
Copy link

@stbenjam: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 889c2dd into openshift:main Oct 9, 2025
20 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

@neisw: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments